Add metrics for the shadow autopilot #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Nov 28, 2023
Comment on lines
+33
to
+34
| // can we somehow check that we keep processing auctions? | ||
| true |
There was a problem hiding this comment.
We could make the Liveness struct part of the shared server state and update a timestamp whenever some solver processed an auction.
Then is_alive() would check that this timestamp is not older than some healthy duration.
sunce86
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When changing the shadow infra over to the colocated architecture, we need to also create a replacement for the shadow solver dashboard. This PR prepares this.
Changes
How to test
Running locally and checking http://localhost:9589/metrics
Will update the dashboard once this is merged.