Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: incorrect openapi.yml for DuplicateOrder #1928

Closed
mfw78 opened this issue Oct 8, 2023 · 0 comments · Fixed by #1929
Closed

bug: incorrect openapi.yml for DuplicateOrder #1928

mfw78 opened this issue Oct 8, 2023 · 0 comments · Fixed by #1929
Assignees
Labels
bug Something isn't working

Comments

@mfw78
Copy link
Contributor

mfw78 commented Oct 8, 2023

Problem

When attempting to add an order to the API more than once, the API returns DuplicatedOrder, despite the openapi.yml indicating it should be DuplicateOrder.

Impact

With a recent push to reduce API resource consumption, this may result in excessive programmatic retries of the API, leading to excessive resource consumption.

To reproduce

  1. Use https://api.cow.fi/docs/#/
  2. Attempt to post the same order twice.
  3. Observe the second attempt showing DuplicateOrder.

Expected behaviour

The API gives the correct response according to the openapi.yml.

services version/commit hash and environment

Version: v2.226.00
Environment: production (mainnet)

Additional context

This error was found during the course of testing the watch tower.

@mfw78 mfw78 added the bug Something isn't working label Oct 8, 2023
@mfw78 mfw78 self-assigned this Oct 8, 2023
mfw78 added a commit that referenced this issue Oct 8, 2023
# Description
Fixes the OpenAPI yaml description for down-stream consumers.

# Changes

- [x] Corrected `DuplicatedOrder` response

## How to test

1. Attempt to place the same order twice.
2. Observe correct API response per `openapi.yml`.

## Related Issues

Fixes #1928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant