Align with the updated Rust (#3142)

Fixes the code to satisfy `clippy`.

Some Derivative annotations were replaced with custom implementation due
to the following weird error, which I couldn't mute even with
`#[allow(clippy::needless_lifetimes)]`.
```
53 | #[derive(Clone, PartialEq, Eq, Hash, Default, Serialize, Derivative)]
   |                                                          ^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
   = note: this error originates in the derive macro `Derivative` (in Nightly builds, run with -Z macro-backtrace for more info)
```

crates/app-data/src/app_data.rs

@@ -175,7 +175,7 @@ impl<'de> Deserialize<'de> for OrderUid {
         D: Deserializer<'de>,
     {
         struct Visitor {}
-        impl<'de> de::Visitor<'de> for Visitor {
+        impl de::Visitor<'_> for Visitor {
             type Value = OrderUid;
 
             fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

crates/autopilot/src/infra/solvers/dto/solve.rs

@@ -188,7 +188,7 @@ where
 {
     struct SolutionIdVisitor;
 
-    impl<'de> serde::de::Visitor<'de> for SolutionIdVisitor {
+    impl serde::de::Visitor<'_> for SolutionIdVisitor {
         type Value = u64;
 
         fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {

crates/chain/src/lib.rs

@@ -129,7 +129,7 @@ impl<'de> Deserialize<'de> for Chain {
     {
         struct NetworkVisitor;
 
-        impl<'de> de::Visitor<'de> for NetworkVisitor {
+        impl de::Visitor<'_> for NetworkVisitor {
             type Value = Chain;
 
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {

crates/driver/src/tests/setup/mod.rs

@@ -1194,7 +1194,7 @@ impl<'a> Solve<'a> {
     }
 }
 
-impl<'a> SolveOk<'a> {
+impl SolveOk<'_> {
     fn solutions(&self) -> Vec<serde_json::Value> {
         #[derive(serde::Deserialize)]
         struct Body {

crates/driver/src/util/serialize/hex.rs

@@ -11,7 +11,7 @@ impl<'de> DeserializeAs<'de, Vec<u8>> for Hex {
     fn deserialize_as<D: Deserializer<'de>>(deserializer: D) -> Result<Vec<u8>, D::Error> {
         struct Visitor;
 
-        impl<'de> de::Visitor<'de> for Visitor {
+        impl de::Visitor<'_> for Visitor {
             type Value = Vec<u8>;
 
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
@@ -50,7 +50,7 @@ impl<'de, const N: usize> DeserializeAs<'de, [u8; N]> for Hex {
             result: [u8; N],
         }
 
-        impl<'de, const N: usize> de::Visitor<'de> for Visitor<N> {
+        impl<const N: usize> de::Visitor<'_> for Visitor<N> {
             type Value = [u8; N];
 
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {

crates/driver/src/util/serialize/u256.rs

@@ -12,7 +12,7 @@ impl<'de> DeserializeAs<'de, eth::U256> for U256 {
     fn deserialize_as<D: Deserializer<'de>>(deserializer: D) -> Result<eth::U256, D::Error> {
         struct Visitor;
 
-        impl<'de> de::Visitor<'de> for Visitor {
+        impl de::Visitor<'_> for Visitor {
             type Value = eth::U256;
 
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {

crates/model/src/order.rs

@@ -1,5 +1,6 @@
 //! Contains the order type as described by the specification with serialization
 //! as described by the openapi documentation.
+#![allow(clippy::needless_lifetimes)] // todo: migrate from derivative to derive_more
 
 use {
     crate::{
@@ -819,7 +820,7 @@ impl<'de> Deserialize<'de> for OrderUid {
         D: Deserializer<'de>,
     {
         struct Visitor {}
-        impl<'de> de::Visitor<'de> for Visitor {
+        impl de::Visitor<'_> for Visitor {
             type Value = OrderUid;
 
             fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -1009,13 +1010,6 @@ impl BuyTokenDestination {
     }
 }
 
-pub fn debug_app_data(
-    app_data: &[u8; 32],
-    formatter: &mut std::fmt::Formatter,
-) -> Result<(), std::fmt::Error> {
-    formatter.write_fmt(format_args!("{:?}", H256(*app_data)))
-}
-
 pub fn debug_biguint_to_string(
     value: &BigUint,
     formatter: &mut std::fmt::Formatter,

crates/model/src/quote.rs

@@ -184,7 +184,6 @@ impl Default for Validity {
 }
 
 /// Helper struct for `Validity` serialization.
-
 impl<'de> Deserialize<'de> for Validity {
     fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
     where

crates/model/src/signature.rs

@@ -385,7 +385,7 @@ impl<'de> Deserialize<'de> for EcdsaSignature {
         D: serde::Deserializer<'de>,
     {
         struct Visitor {}
-        impl<'de> de::Visitor<'de> for Visitor {
+        impl de::Visitor<'_> for Visitor {
             type Value = EcdsaSignature;
 
             fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

crates/number/src/serialization.rs

@@ -37,7 +37,7 @@ where
     D: Deserializer<'de>,
 {
     struct Visitor {}
-    impl<'de> de::Visitor<'de> for Visitor {
+    impl de::Visitor<'_> for Visitor {
         type Value = U256;
 
         fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

crates/shared/src/baseline_solver.rs

@@ -39,7 +39,7 @@ pub struct Estimate<'a, V, L> {
     pub path: Vec<&'a L>,
 }
 
-impl<'a, V, L: BaselineSolvable> Estimate<'a, V, L> {
+impl<V, L: BaselineSolvable> Estimate<'_, V, L> {
     pub fn gas_cost(&self) -> usize {
         // This could be more accurate by actually simulating the settlement (since
         // different tokens might have more or less expensive transfer costs)

crates/shared/src/price_estimation/native_price_cache.rs

@@ -115,7 +115,7 @@ impl Inner {
         &'a self,
         tokens: &'a [H160],
         max_age: Duration,
-    ) -> futures::stream::BoxStream<'_, (H160, NativePriceEstimateResult)> {
+    ) -> futures::stream::BoxStream<'a, (H160, NativePriceEstimateResult)> {
         let estimates = tokens.iter().map(move |token| async move {
             {
                 // check if price is cached by now

crates/shared/src/trade_finding/mod.rs

@@ -1,5 +1,6 @@
 //! A module for abstracting a component that can produce a quote with calldata
 //! for a specified token pair and amount.
+#![allow(clippy::needless_lifetimes)] // todo: migrate from derivative to derive_more
 
 pub mod external;
 

crates/solver/src/liquidity/slippage.rs

@@ -22,7 +22,7 @@ pub struct SlippageContext<'a> {
     calculator: &'a SlippageCalculator,
 }
 
-impl<'a> SlippageContext<'a> {
+impl SlippageContext<'_> {
     /// Returns the external prices used for the slippage context.
     pub fn prices(&self) -> &ExternalPrices {
         self.prices

crates/solvers-dto/src/lib.rs

@@ -19,7 +19,7 @@ mod serialize {
         fn deserialize_as<D: Deserializer<'de>>(deserializer: D) -> Result<Vec<u8>, D::Error> {
             struct Visitor;
 
-            impl<'de> de::Visitor<'de> for Visitor {
+            impl de::Visitor<'_> for Visitor {
                 type Value = Vec<u8>;
 
                 fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
@@ -58,7 +58,7 @@ mod serialize {
                 result: [u8; N],
             }
 
-            impl<'de, const N: usize> de::Visitor<'de> for Visitor<N> {
+            impl<const N: usize> de::Visitor<'_> for Visitor<N> {
                 type Value = [u8; N];
 
                 fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {