-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tutorial webcontainer refactoring and sdk examples #4
Conversation
shoom3301
commented
Dec 13, 2023
•
edited
Loading
edited
- Changed the tutorial webcontainer app from Svelte to Vanilla typescript
- Set up a couple of examples for SDK usages
- Added an example of app-data SDK usage
@shoom3301 is attempting to deploy a commit to the cow Team on Vercel. To accomplish this, @shoom3301 needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is protestware and troll packages?This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function. Consider that consuming this package my come along with functionality unrelated to its primary purpose. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
This is great! As mentioned on the call, if we can please include an example for |
"@cowprotocol/cow-sdk": "^4.0.3", | ||
"ethers": "^5.7.2" | ||
} | ||
"name": "my-vue-app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anxolin 's favourite 😁
import type { Web3Provider } from '@ethersproject/providers' | ||
|
||
export async function run(provider: Web3Provider): Promise<unknown> { | ||
console.log(provider) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we want this in prod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a default file, it should not be executed
import './types.ts' | ||
|
||
import { Buffer } from 'buffer' | ||
window.Buffer = Buffer // Yep, this is a hack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨💻
@shoom3301 's PR cowprotocol/docs#9 Tutorial how to create a pre-signed order using Safe --------- Co-authored-by: shoom3301 <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|