Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes reentrancy checks in preparation for the audit.
We introduced reentracy checks after this discussion.
There is no plan of implementing the order update function before the audit or before deploying the first version of the ETH flow contract. The order update function and its extra reentrancy risks was the main motivations for the reentrancy guard, so there is no reason to keep the guard until development of a new contract version with this feature starts.
Note that reentrancy between
createOrder
anddeleteOrder
does not help an attacker. No instructions after the reentrancy entry point read or write the storage of the contract, so calling a function while reentering would be equivalent to calling a function after the call todeleteOrder
is finished.Test plan
Existing tests.