Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block wallet integration #2212

Closed
wants to merge 1 commit into from
Closed

Block wallet integration #2212

wants to merge 1 commit into from

Conversation

nenadV91
Copy link
Contributor

Summary

Adds a block wallet option in wallet modal

There are some issues with this wallet

  1. If there is Metamask installed, we can't connect to this wallet.
  2. If there is Tally wallet installed, we can select the provider for this wallet but we can't connect to it and I've opened an issue here

Screenshot 2023-03-01 at 13 34 00

@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback

🌃 Cosmos ↗︎

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nenadV91 for the two issues, if i understand, we don't care too much.

If another plugin is causing a collision, is not our fault. You should use the standard to select the injected wallet, and that should be good enough IMO.

I tried and it worked to connect and wrap. But I don't think the balances are being updated. At least i sent some COW and didn't update my account. Also when i did the WRAP it didn't
change my ETH balance or my WETH balance

image

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit, i approve since it end up working.

Didn't feel like the most reliable wallet, but i manage to trade. I guess before the RPC was failing for them and took a bit to show the new balances.

Copy link
Collaborator

@shoom3301 shoom3301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft approve.
Haven't tested the behaviour, but the code looks good!

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nenadV91 , transactions work (onchain and offchain) when connect to the wallet.
However, some issues:

  1. There is no wallet icon on the Account modal/waiting modals when sign a transaction
    no image

  2. The wallet can be installed to the Chrome and Brave browsers only I think, we need to disabled Blockwallet button for all the rest browsers and for mobile app version (we did it for Tally)

  3. When TX is in progress, I see the totally red console:
    console
    image

  4. As @anxolin noticed, balances are loaded\updated with a delay (not sure if we could fix this :)

Thanks!

@shoom3301 shoom3301 closed this Aug 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
@alfetopito alfetopito deleted the wallet/block branch August 15, 2023 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants