-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block wallet integration #2212
Block wallet integration #2212
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nenadV91 for the two issues, if i understand, we don't care too much.
If another plugin is causing a collision, is not our fault. You should use the standard to select the injected wallet, and that should be good enough IMO.
I tried and it worked to connect and wrap. But I don't think the balances are being updated. At least i sent some COW and didn't update my account. Also when i did the WRAP it didn't
change my ETH balance or my WETH balance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit, i approve since it end up working.
Didn't feel like the most reliable wallet, but i manage to trade. I guess before the RPC was failing for them and took a bit to show the new balances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soft approve.
Haven't tested the behaviour, but the code looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nenadV91 , transactions work (onchain and offchain) when connect to the wallet.
However, some issues:
-
There is no wallet icon on the Account modal/waiting modals when sign a transaction
-
The wallet can be installed to the Chrome and Brave browsers only I think, we need to disabled Blockwallet button for all the rest browsers and for mobile app version (we did it for Tally)
-
As @anxolin noticed, balances are loaded\updated with a delay (not sure if we could fix this :)
Thanks!
Summary
Adds a block wallet option in wallet modal
There are some issues with this wallet