fix: cow-shed types #224
Merged
fix: cow-shed types #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary CoW-shed was using absolute imports in some places which causes the generated types to not find the the proper imports. Changed it to relative. # Testing In this lib all tests were passing as before. The issue was when importing it on watch-tower. I built it with `yalc`, published locally and installed onto watch-tower. After that the build was successful.
|
Please post merge review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CoW-shed was using absolute imports in some places which causes the generated types to not find the the proper imports.
Changed it to relative.
This is causing the watch-tower
tsccommand to fail: https://github.com/cowprotocol/watch-tower/actions/runs/11722358815/job/32651723873?pr=162Testing
In this lib all tests were passing as before.
The issue was when importing it on watch-tower.
I built it with
yalc, published locally and installed onto watch-tower.After that the build was successful.