Mock class and implement custom polling test #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR verifies that the child class always have the last word when we are polling, and can signal what should be the result.
It adds 6 new tests for the different outcomes of
pollValidate
:The tests were a bit repetitive, so for this one i created a shared function. After all, i just want to test for all case, the
poll
will respect what thepollValidate
says, so i just want to see it handles expectations, and all the result codes.Note that I had to extend the test order class to be able to override and mock
pollValidate
(its protected, which makes it harder to mock)