[Polling tests] Add Handle unexpected errors #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, validations, if done right, will catch all errors and return a comprehensive error.
This is why, by the time we do the call to
getTradeableOrderWithSignature
we will have quite some certainty the call will succeed. If it doesn't we will consider it anUNEXPECTED_ERROR
and will return the original error with the result.This PR adds a unit test to validate we get this result in this situation.