Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Polling tests] Add Handle unexpected errors #162

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Sep 1, 2023

Normally, validations, if done right, will catch all errors and return a comprehensive error.

This is why, by the time we do the call to getTradeableOrderWithSignature we will have quite some certainty the call will succeed. If it doesn't we will consider it an UNEXPECTED_ERROR and will return the original error with the result.

This PR adds a unit test to validate we get this result in this situation.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@anxolin anxolin changed the title Add Handle unexpected errors [Polling tests] Add Handle unexpected errors Sep 1, 2023
@anxolin anxolin requested review from mfw78 and a team September 1, 2023 14:34
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit on in-line logic of comment.

src/composable/ConditionalOrder.spec.ts Outdated Show resolved Hide resolved
@anxolin anxolin force-pushed the handle-unexpected-errors branch from 2842c9d to ef26761 Compare September 1, 2023 16:10
@anxolin anxolin changed the base branch from is-valid to main September 1, 2023 16:10
Co-authored-by: mfw78 <[email protected]>
@anxolin anxolin merged commit 228ff3e into main Sep 1, 2023
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
@alfetopito alfetopito deleted the handle-unexpected-errors branch September 4, 2023 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants