Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(headless): add globalThis shim to quanticUmd build to fix a bug with Locker Service #4701

Merged
merged 5 commits into from
Nov 25, 2024
Merged

fix(headless): add globalThis shim to quanticUmd build to fix a bug with Locker Service #4701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3274a0
fix(headless): add globalThis shim to quanticUmd build to fix a bug w…
erocheleau Nov 22, 2024
2e27743
don't override globalThis if it already exist
erocheleau Nov 22, 2024
e2317e8
Disable LWS for scratch orgs
erocheleau Nov 22, 2024
b581042
re-add LWS for speed, will fix with Locker later
erocheleau Nov 23, 2024
69ff16e
Merge branch 'master' into SFINT-5840
erocheleau Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/headless/esbuild.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ const quanticUmd = Object.entries(quanticUseCaseEntries).map((entry) => {
},
external: ['crypto'],
inject: [
'ponyfills/global-this-shim.js',
'ponyfills/abortable-fetch-shim.js',
'../../node_modules/navigator.sendbeacon/dist/navigator.sendbeacon.cjs.js',
],
Expand Down
4 changes: 4 additions & 0 deletions packages/headless/ponyfills/global-this-shim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// Shim globalThis because Salesforce Locker Service doesn't support it.
const globalThisShim = typeof globalThis !== 'undefined' ? globalThis : window;

export {globalThisShim as globalThis};
Loading