fix: patch-up support for merge_group
#42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
changed the title
merge_group
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
1 similar comment
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| @@ -58,3 +58,5 @@ jobs: | |||
| comment-summary-in-pr: ${{ inputs.comment-summary-in-pr }} | |||
| fail-on-severity: high | |||
| config-file: ./coveo-dependency-allowed-licenses/${{ steps.select-config.outputs.result }} | |||
| base-ref: ${{ github.event.pull_request.base.sha || 'main' }} | |||
There was a problem hiding this comment.
What about repos like platform-client that have a master branch instead of main? Maybe we could define inputs instead which would be more flexible? I started a branch yesterday without knowing you were also working on this. 😅
There was a problem hiding this comment.
Oops! I jumped the gun. I prefer your approach, let's use it 👍
However, after actions/dependency-review-action#766, I think we should remove the default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From actions/dependency-review-action#456 (comment), find out by @aboissinot-coveo 👏
Will be fixed upstream by actions/dependency-review-action#766.