Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATALAD] Added glm-memory subdataset #82

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[DATALAD] Added glm-memory subdataset #82

wants to merge 3 commits into from

Conversation

emdupre
Copy link
Collaborator

@emdupre emdupre commented Jan 16, 2025 •
edited
Loading

  • modif to main README and THINGS/README files
  • the submodule (structure similar to THINGS/behaviour w code repo, doc for pipeline, and bids structured sub-0*/glm/* results files pushed to S3

@emdupre emdupre marked this pull request as ready for review January 16, 2025 18:30
@emdupre
Copy link
Collaborator Author

emdupre commented Jan 16, 2025

I think this is ready for review ! It looks like the tests have been failing for a little while now, so I'm assuming those failures are expected ?

@emdupre
Copy link
Collaborator Author

emdupre commented Jan 17, 2025

@MarieStLaurent confirming that

  1. the sub-module is updated after re-running dropping sub-06/ses-08/run-06 and
  2. that I've updated my file globbing to look for the appropriate digit padding for each BIDS entity (i.e., ses and run), depending on whether it's pulling from sourcedata or the fmriprep derivs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emdupre