Add a separate property, isCacheable, to SharedKeys. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianminzhao
force-pushed
the
cbl-4547-fleece
branch
from
7ad9752 to
8499ba2
Compare
If cacheable, Dict::get(key &keyToFind) will cache the string key to integer key and enhance the performance of the ensuing gets. This is good if the doucment is not changed. For PersistentSharedKey, the library manages the property: it is cacheable only if it is not in a transaction when Dict::get is called. For SharedKeys, the client manages it. If it anticipates the sharedKeys may outlive the underlying document changes, it should call SharedKeys::disableCaching().
jianminzhao
force-pushed
the
cbl-4547-fleece
branch
from
8499ba2 to
60ca3bc
Compare
snej
requested changes
Dec 4, 2023
|
The reason of LITECORE_CPPTEST is because the automatic tests are run from LiteCore. The cmake project of CppTests lumps all tests from fleece with the LiteCore's tests. |
|
I would rather not have stuff in Fleece that's so directly tied to LiteCore. The test stuff in LiteCore could define FLEECE_TEST as well. |
|
Or you could get around the need for a special macro by adding a public method to access |
jianminzhao
commented
Dec 9, 2023
| @@ -262,7 +262,7 @@ namespace fleece { | |||
|
|
|||
| caughtException = false; | |||
| // ++iter will throw if already at the end. | |||
| // OutOfRange exception should contain the backtrace. | |||
| // OutOfRange exception should not contain the backtrace. | |||
There was a problem hiding this comment.
This is a mistake. Should be "... not contain the backtrace."
snej
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If cacheable, Dict::get(key &keyToFind) will cache the string key to integer key and enhance the performance of the ensuing gets. This is good if the doucment is not changed.
For PersistentSharedKey, the library manages the property: it is cacheable only if it is not in a transaction when Dict::get is called.
For SharedKeys, the client manages it. If it anticipates the sharedKeys may outlive the underlying document changes, it should call SharedKeys::disableCaching().