Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.1 SPM #3344

Merged
merged 1 commit into from
Nov 13, 2024
Merged

3.2.1 SPM #3344

merged 1 commit into from
Nov 13, 2024

Conversation

velicuvlad
Copy link
Contributor

No description provided.

@velicuvlad
Copy link
Contributor Author

Jenkins - testCBLVersionAndLiteCoreVersion failing due to the fact that underlying LiteCore XCode project remained under 3.2.0 (known issue).

@velicuvlad velicuvlad requested review from bmeike and pasin November 13, 2024 13:43
Copy link
Contributor

@bmeike bmeike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again: should this change have gone into 3.2.1
Should this now be 3.2.2?

@velicuvlad
Copy link
Contributor Author

@bmeike the only thing that could've been was the project version change, but that is taken automatically from the build args when we do binaries, but the Jenkins would've fail for every PR because of the mismatch. This was caught by Jim last week, after Core RC.

The rest is SPM specific, as we hold the CE here next to the source. This is a thing that will be changed for 4.0, will move under the separate repo https://github.com/couchbase/couchbase-lite-swift-ee , next to the EE, so this additional commit wont be needed finally.

@velicuvlad velicuvlad merged commit f2d4fba into release/3.2 Nov 13, 2024
9 of 10 checks passed
@velicuvlad velicuvlad deleted the 3.2.1-spm branch November 13, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants