CBL-5736: Implement copy for MutableDocument and test #3340
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
requested changes
Nov 18, 2024
|
|
||
| @return The CBLMutableDocument object. | ||
| */ | ||
| - (CBLMutableDocument*) copy; |
There was a problem hiding this comment.
I might be wrong as it has been awhile. I don't remember if we need to explicity define this as the copy is a part of NSObject protocol.
There was a problem hiding this comment.
I've searched for it and found that is part of NSObject now. I've tried it before in CBL and copy didnt work (the reason I've filed the ticket in the first place...)
| @@ -119,6 +119,10 @@ - (CBLMutableDocument*) mutableCopyWithZone: (NSZone *)zone { | |||
| return [[CBLMutableDocument alloc] initAsCopyWithDocument: self dict: _dict]; | |||
| } | |||
|
|
|||
| - (CBLMutableDocument*) copy { | |||
| return [self mutableCopyWithZone: nil]; | |||
There was a problem hiding this comment.
I don't remember if the default copy calls mutableCopyWithZone or not. Can you double check?
| @@ -97,10 +97,18 @@ public final class MutableDocument : Document, MutableDictionaryProtocol { | |||
| /// Returns the same MutableDocument object. | |||
| /// | |||
| /// - Returns: The MutableDocument object. | |||
| @available(*, deprecated, message: "Use mutableDocument.copy() instead.") | |||
There was a problem hiding this comment.
We shouldn't deprecate this as toMutable() is our cross-platform API.
|
Will close this PR as is not relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obj-C
CBLMutableDocumentnow implements(CBLMutableDocument*) copySwift
MutableDocumenttoMutable()marked as deprecated andcopy()replacement