CBL-5661 : Fix a released captured context may be used in observer callback #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage Results:
|
pasin
requested review from
velicuvlad,
jianminzhao and
bmeike
and removed request for
bmeike,
velicuvlad and
jianminzhao
…llback * Implemented ContextManager class for retaining and mapping callback context objects with their pointer value. When getting the object back, the retained object will be returned so the object can be safely used in the callback. * Updated ListenerToken<CBLQueryChangeListener> to use ContextManager for it’s C4QueryObserver’s callback lamda so that the callback can validate and safely use its captured context. * Added CBLQuery_SetListenerCallbackDelay() private API for testing the fix. * Updated LiteCore to 3.1.7-1 to get the fix for CBSE-16662.
velicuvlad
reviewed
Apr 23, 2024
Comment on lines
+91
to
+96
| void CBLQuery_SetListenerCallbackDelay(int delayMS) noexcept { | ||
| #ifdef DEBUG | ||
| ListenerToken<CBLQueryChangeListener>::setC4QueryObserverCallbackDelay(delayMS); | ||
| #endif | ||
| } | ||
|
|
There was a problem hiding this comment.
this method is not exposed for swift unless is debug (including the definition). Can we have it the same here?
#ifdef DEBUG
void CBLQuery_SetListenerCallbackDelay(int delayMS) noexcept { ... }
#endif
There was a problem hiding this comment.
The method needs to be exposed in the public symbols like the other methods in the private header file so that the C test program can use. I don’t want to have the public symbols points to non existing symbols. The private headers will not be available publicly and the method will do nothing in release build.
velicuvlad
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented ContextManager class for retaining and mapping callback context objects with their pointer value. When getting the object back, the retained object will be returned so the object can be safely used in the callback.
Updated ListenerToken to use ContextManager for it’s C4QueryObserver’s callback lamda so that the callback can validate and safely use its captured context.
Added CBLQuery_SetListenerCallbackDelay() private API for testing the fix.
Updated LiteCore to 3.1.7-1 to get the fix for CBSE-16662.