minor cleanup and fixed missing Add from session manager #1
cosullivanAnnotations
10 warnings
|
build:
Src/SmtpServer.Benchmarks/Program.cs#L19
'ConfigExtensions.With(IConfig, ConfigOptions)' is obsolete: 'This method will soon be removed, please start using .WithOptions() instead.'
|
|
build:
Src/SmtpServer.Tests/SmtpServerTests.cs#L48
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)
|
|
build:
Src/SmtpServer.Tests/PipeReaderTests.cs#L43
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
|
|
build:
Src/SmtpServer.Tests/PipeReaderTests.cs#L28
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
|
|
build:
Src/SmtpServer.Tests/PipeReaderTests.cs#L58
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
|
|
build:
Src/SmtpServer.Tests/PipeReaderTests.cs#L59
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
|
|
build:
Src/SmtpServer.Tests/PipeReaderTests.cs#L60
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
|
|
build:
Src/SmtpServer.Tests/SmtpServerTests.cs#L155
Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. (https://xunit.net/xunit.analyzers/rules/xUnit1031)
|
|
build:
Src/SmtpServer.Tests/SmtpServerTests.cs#L159
Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. (https://xunit.net/xunit.analyzers/rules/xUnit1031)
|
|
build:
Examples/SampleApp/Examples/CommonPortsExample.cs#L27
'X509Certificate2.X509Certificate2()' is obsolete: 'X509Certificate and X509Certificate2 are immutable. Use the appropriate constructor to create a new certificate.' (https://aka.ms/dotnet-warnings/SYSLIB0026)
|