create custom rollkit ClientState type

[crodriguezvega]

No description provided.

[rnbguy]

Hey, cosmos/ibc-rs#1204 relaxes the TryFrom<Error = ClientError> restriction. If you are using the latest branch from ibc-rs, you can just do this

use ibc_client_cw::api::ClientType;
use ibc_client_tendermint::consensus_state::ConsensusState as TendermintConsensusState;

use crate::client_state::ClientState as RollkitClientState;

pub struct RollkitClient;

impl<'a> ClientType<'a> for RollkitClient {
    type ClientState = RollkitClientState;
    type ConsensusState = TendermintConsensusState;
}

You can refer to the current implementation of the Tendermint CW client.

PS: We reversed the direction of Convertible and dropped Error generic. So,

V::ConsensusStateRef: Convertible<TendermintConsensusStateType, ClientError>,

becomes

TendermintConsensusStateType: Convertible<V::ConsensusStateRef>

Sometimes you may need to add

ClientError: From<<TendermintConsensusStateType as TryFrom<V::ConsensusStateRef>>::Error>

for ClientError conversion.

[crodriguezvega]

Hey, cosmos/ibc-rs#1204 relaxes the TryFrom<Error = ClientError> restriction. If you are using the latest branch from ibc-rs, you can just do this

use ibc_client_cw::api::ClientType;
use ibc_client_tendermint::consensus_state::ConsensusState as TendermintConsensusState;

use crate::client_state::ClientState as RollkitClientState;

pub struct RollkitClient;

impl<'a> ClientType<'a> for RollkitClient {
    type ClientState = RollkitClientState;
    type ConsensusState = TendermintConsensusState;
}

You can refer to the current implementation of the Tendermint CW client.

PS: We reversed the direction of Convertible and dropped Error generic. So,

V::ConsensusStateRef: Convertible<TendermintConsensusStateType, ClientError>,

becomes

TendermintConsensusStateType: Convertible<V::ConsensusStateRef>

Sometimes you may need to add

ClientError: From<<TendermintConsensusStateType as TryFrom<V::ConsensusStateRef>>::Error>

for ClientError conversion.

Thank you for the heads up, @rnbguy. I have updated to the tip of ibc-rs and implemented the suggested changes.

[crodriguezvega]

@rnbguy Would you happen to know if this can be simplified? Doing just consensus_state.try_into() was giving me errors about the ClientError, and this is what I came up with to work around them...

[rnbguy]

Very interesting find. Looks like the Rust compiler is getting confused between the implementations for TryFrom<Any> and TryFrom<E::ConsensusStateRef>.

For this particular code, you can remove this trait bound, and that allows .try_into()?.

If we really needed that trait bound, you could have done:

let tendermint_consensus_state =
  <TendermintConsensusStateType as TryFrom<Any>>::try_from(consensus_state.clone())?;

[rnbguy]

I pushed a commit for this 31babdb

[crodriguezvega]

Thanks for the suggestion, @rnbguy! I will try the removal of the trait bound for now. :)

[crodriguezvega]

This looks good to me for now. No tests (yet), but we'll figure out how to best do that later on. Merging now...