chore: More rigorous CosmWasm check and upgrade dependencies #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzmitry-lahoda
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
=======================================
Coverage 70.86% 70.86%
=======================================
Files 178 178
Lines 17918 17918
=======================================
Hits 12698 12698
Misses 5220 5220 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Hey @dzmitry-lahoda, thanks for the improvements!
The primitive-types/std glitch should be fixed on the parity-common. I've opened this PR there and tested locally. It worked.
Let's wrap up the acceptable changes of this PR. But we'll keep issue #991 open until parity's sorted.
.changelog/unreleased/improvements/992-making-cosmwasm-compile-apps-transfers.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Farhad Shabani <[email protected]> Signed-off-by: dzmitry-lahoda <[email protected]>
Co-authored-by: Farhad Shabani <[email protected]> Signed-off-by: dzmitry-lahoda <[email protected]>
…-apps-transfers.md Co-authored-by: Farhad Shabani <[email protected]> Signed-off-by: dzmitry-lahoda <[email protected]>
Signed-off-by: dzmitry-lahoda <[email protected]>
Farhad-Shabani
changed the title
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* clean up * remaining * up * spelling * true check * better nix - features enabled + gh cache integration * flag * Update ci/cw-check/Cargo.toml Co-authored-by: Farhad Shabani <[email protected]> Signed-off-by: dzmitry-lahoda <[email protected]> * Update ci/cw-check/README.md Co-authored-by: Farhad Shabani <[email protected]> Signed-off-by: dzmitry-lahoda <[email protected]> * Update .changelog/unreleased/improvements/992-making-cosmwasm-compile-apps-transfers.md Co-authored-by: Farhad Shabani <[email protected]> Signed-off-by: dzmitry-lahoda <[email protected]> * Update Cargo.toml Signed-off-by: dzmitry-lahoda <[email protected]> --------- Signed-off-by: dzmitry-lahoda <[email protected]> Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #991
Description
Parity primitives-types are disallowed for wasm32 and std.
But because in wasm32 std and no std bind to same types, can use parity types without std in wasm32 or native.
In case of when std != no_std (for example Solana), it is not wasm and no_std, so it should work too.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.