Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump ibc-proto-rs to v0.38.0 + some other dependency upgrades #949

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Nov 7, 2023

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (1ec4b8c) 0.00% compared to head (eff17e4) 67.72%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #949       +/-   ##
=========================================
+ Coverage      0   67.72%   +67.72%     
=========================================
  Files         0      130      +130     
  Lines         0    16491    +16491     
=========================================
+ Hits          0    11168    +11168     
- Misses        0     5323     +5323     
Files Coverage Δ
crates/ibc-derive/src/consensus_state.rs 98.18% <100.00%> (ø)
crates/ibc/src/applications/transfer/error.rs 29.16% <ø> (ø)
...s/ibc/src/clients/ics07_tendermint/client_state.rs 74.31% <100.00%> (ø)
crates/ibc/src/clients/ics07_tendermint/header.rs 72.81% <100.00%> (ø)
...s/ibc/src/clients/ics07_tendermint/misbehaviour.rs 67.36% <100.00%> (ø)
...bc/src/clients/ics07_tendermint/trust_threshold.rs 59.32% <ø> (ø)
crates/ibc/src/core/context.rs 51.51% <ø> (ø)
crates/ibc/src/core/ics02_client/error.rs 25.00% <ø> (ø)
crates/ibc/src/core/ics02_client/height.rs 91.25% <ø> (ø)
...es/ibc/src/core/ics02_client/msgs/create_client.rs 84.37% <ø> (ø)
... and 40 more

... and 80 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Farhad-Shabani Thanks for taking care of this. 🙏 Just requested a change.

ci/no-std-check/Cargo.toml Show resolved Hide resolved
crates/ibc/src/core/ics03_connection/error.rs Show resolved Hide resolved
Farhad-Shabani and others added 2 commits November 7, 2023 09:22
Co-authored-by: Rano | Ranadeep <[email protected]>
Signed-off-by: Farhad Shabani <[email protected]>
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Farhad-Shabani 🤝

@Farhad-Shabani Farhad-Shabani merged commit 527bb14 into main Nov 7, 2023
14 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/bump-ibc-proto-to-v0380 branch November 7, 2023 18:10
@Farhad-Shabani Farhad-Shabani added this to the v0.48.0 milestone Nov 24, 2023
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
…#949)

* deps: bump ibc-proto-rs to v0.38.0 + some other dependency upgrades

* chore: add unclog

* nit: unclog link

Co-authored-by: Rano | Ranadeep <[email protected]>
Signed-off-by: Farhad Shabani <[email protected]>

* deps: upgrade some others

---------

Signed-off-by: Farhad Shabani <[email protected]>
Co-authored-by: Rano | Ranadeep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants