Implement consensus state pruning for Tendermint clients #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sensus-state-pruning
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage ? 67.65%
=======================================
Files ? 130
Lines ? 16415
Branches ? 0
=======================================
Hits ? 11105
Misses ? 5310
Partials ? 0
☔ View full report in Codecov by Sentry. |
crates/ibc/src/clients/ics07_tendermint/client_state/update_client.rs
Outdated
Show resolved
Hide resolved
crates/ibc/src/clients/ics07_tendermint/client_state/update_client.rs
Outdated
Show resolved
Hide resolved
Farhad-Shabani
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
All set from my end. See if the added unit test makes sense to you, we can merge. 🎉
Thanks @seanchen1991 for taking care of this!
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* Add prune_oldest_consensus_state to ClientStateValidation * Add consensus_state_heights fn signature to CommonContext * Stub prune_oldest_consensus_state fn * Add comments for delete_update_time and delete_update_height * Clean up code structure a bit * Fix some compilation errors * Address all compilation errors resulting from prune_old_consensus_states * Move delete_update_height and delete_update_time methods to ExecutionContext trait * Clean up all compilation errors * Disambiguate some method calls * Fix fn formatting * Run cargo fmt * Flip consensus state condition check * Add changelog entry * Incorporate PR feedback * test: add test_cons_state_pruning * Simplify consensus state pruning unit test a bit * Document `test_consensus_state_pruning` function * Correct a detail in documentation --------- Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #600
Description
Implements consensus state pruning for Tendermint clients.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.