Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: tendermint client update when client expires or validator set has changed #920

Closed
wants to merge 6 commits into from
Closed

test: tendermint client update when client expires or validator set has changed #920

wants to merge 6 commits into from

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Oct 13, 2023

Closes: #538

Description

This PR adds and modifies a few test scenarios.

  1. Client expiry while client state update.
  2. Client state update with validator set changes (happy and sad).

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy requested a review from Farhad-Shabani October 13, 2023 16:03
@rnbguy rnbguy self-assigned this Oct 13, 2023
@rnbguy rnbguy closed this Oct 13, 2023
@rnbguy rnbguy deleted the rano/test-client-expiry branch October 13, 2023 16:06
@rnbguy rnbguy restored the rano/test-client-expiry branch October 13, 2023 16:06
@rnbguy rnbguy deleted the rano/test-client-expiry branch October 13, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farhad-Shabani Farhad-Shabani Awaiting requested review from Farhad-Shabani

Assignees

@rnbguy rnbguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICS02] Cover client frozen/expired conditions with unit tests
1 participant
@rnbguy