Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api)!: increase_*_counters methods return Result type #858

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Sep 5, 2023

Closes: #857


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (357f51d) 71.43% compared to head (b00da04) 71.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   71.43%   71.46%   +0.02%     
==========================================
  Files         125      125              
  Lines       15181    15193      +12     
==========================================
+ Hits        10845    10857      +12     
  Misses       4336     4336              
Files Changed Coverage Δ
crates/ibc/src/core/context.rs 50.00% <ø> (ø)
crates/ibc/src/core/ics02_client/error.rs 24.32% <ø> (ø)
crates/ibc/src/core/ics03_connection/error.rs 7.69% <ø> (ø)
crates/ibc/src/core/ics04_channel/error.rs 26.08% <ø> (ø)
...ibc/src/core/ics02_client/handler/create_client.rs 84.93% <100.00%> (-0.21%) ⬇️
...rc/core/ics03_connection/handler/conn_open_init.rs 97.29% <100.00%> (+0.02%) ⬆️
...src/core/ics03_connection/handler/conn_open_try.rs 93.71% <100.00%> (+0.03%) ⬆️
...c/src/core/ics04_channel/handler/chan_open_init.rs 94.31% <100.00%> (-0.13%) ⬇️
...bc/src/core/ics04_channel/handler/chan_open_try.rs 95.90% <100.00%> (-0.07%) ⬇️
crates/ibc/src/mock/context.rs 74.89% <100.00%> (+0.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plafer plafer merged commit 366b394 into main Sep 5, 2023
13 checks passed
@plafer plafer deleted the farhad/857-increase-counters-return-type branch September 5, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increase_*_counter methods should return error in case of overflow
2 participants