Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: implement From<Infallible> for ClientError #1359

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Oct 16, 2024

Closes: #1356

Relevant PR in the cosmwasm-ibc repository: informalsystems/cosmwasm-ibc#3


PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani changed the title imp: implement Infallible for ClientError imp: implement From<Infallible> for ClientError Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.84%. Comparing base (e50ae6c) to head (33d9b86).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ibc-core/ics24-host/types/src/error.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
- Coverage   66.85%   66.84%   -0.01%     
==========================================
  Files         225      225              
  Lines       22628    22631       +3     
==========================================
  Hits        15127    15127              
- Misses       7501     7504       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani requested a review from rnbguy October 16, 2024 18:06
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 but do we need a changelog for this ?

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 5c51c7f Oct 17, 2024
14 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/impl-Infallible-for-ClientError branch October 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

missing From<Infallible> for ClientError
2 participants