fix: use Binary for checksum and merkle path so base64 deser works
#1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
+ Coverage 67.43% 67.45% +0.02%
==========================================
Files 236 236
Lines 23940 23968 +28
==========================================
+ Hits 16144 16168 +24
- Misses 7796 7800 +4 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
changed the title
Binray so base64 deser works
Farhad-Shabani
changed the title
Binray so base64 deser worksBinray so base64 deser works
Farhad-Shabani
changed the title
Binray so base64 deser worksBinary for checksum and merkle path so base64 deser works
rnbguy
force-pushed
the
farhad/serialize-checksum-with-hex
branch
from
6547980 to
f8444e4
Compare
rnbguy
force-pushed
the
farhad/serialize-checksum-with-hex
branch
from
f8444e4 to
8f4661b
Compare
rnbguy
approved these changes
Jul 19, 2024
|
Great! Thank you for the tests, Rano! |
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
…1283) * fix: de/serialize checksum with hex * imp: remove unnecessary cosmwasm feature * chore: add changelog * fix: use Binary as checksum type for InstantiateMsg * chore: update changelog * fix: revert checksum type back to Binary and use base64 deser * chore: update changelog * fix: use Binary for MeklePath + some helper methods * add regression test * update tests --------- Co-authored-by: Ranadeep Biswas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR:
cosmwasmfeature for a better consistency with feature flags across ibc-rs, leveraging existingserdeandschemafeatures.PathBytesandCommitmentPrefixconstruction.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.