Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(08-wasm): supersede Bytes with cosmwasm_std::Binary #1272

Merged
merged 9 commits into from
Jul 11, 2024
Merged

imp(08-wasm): supersede Bytes with cosmwasm_std::Binary #1272

merged 9 commits into from
Jul 11, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Jul 8, 2024 •
edited
Loading

Closes: #1271

PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani mentioned this pull request Jul 8, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.41%. Comparing base (c6420c4) to head (6fd078c).

Files Patch % Lines
ibc-clients/cw-context/src/context/mod.rs 40.00% 9 Missing ⚠️
ibc-clients/cw-context/src/types/msgs.rs 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
- Coverage   67.42%   67.41%   -0.02%     
==========================================
  Files         235      235              
  Lines       23811    23820       +9     
==========================================
+ Hits        16055    16058       +3     
- Misses       7756     7762       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani added this to the 0.54.0 milestone Jul 8, 2024
@Farhad-Shabani Farhad-Shabani requested a review from rnbguy July 10, 2024 17:54
rnbguy
rnbguy approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏 Thanks Farhad !

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit df9653a Jul 11, 2024
19 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/supersede-bytes-with-binary branch July 11, 2024 15:40
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani @rnbguy
imp(08-wasm): supersede Bytes with cosmwasm_std::Binary (#1272)
086e3f3 
* imp: supersede Bytes with cosmwasm_std::Binary

* chore: add unclog

* fix: keep ibc-client-wasm-types as is

* fix: use cosmwasm_std::Checksum

* fix: make clippy happy

* rm unused dependency

* rm redundant import

* fix: move unclog under improvements

---------

Co-authored-by: Ranadeep Biswas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnbguy rnbguy rnbguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
0.54.0
Development

Successfully merging this pull request may close these issues.

Replace the Bytes alias in CosmWasm context with cosmwasm_std::Binary
2 participants
@Farhad-Shabani @rnbguy