-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ibc-core): port capability #1258
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1258 +/- ##
==========================================
+ Coverage 67.27% 67.34% +0.07%
==========================================
Files 235 236 +1
Lines 23538 23635 +97
==========================================
+ Hits 15836 15918 +82
- Misses 7702 7717 +15 ☔ View full report in Codecov by Sentry. |
We do need to locally maintain a capability key for each module. Which should be used to authenticate the modules. This should be unique to each Module type. This is the only way to make sure different modules can't commit packets on the same ports - even though a malicious module tries to forge a Module identifier. The capability keys shouldn't be committed to the blockchain store - as they are local and probably distinct across different builds. We can use |
Closes: #519
ChanOpenInit
andChanOpenTry
.transfer
module can't commit packets for"nft-transfer"
port.""ports/{id}"
.Description
Ref: https://github.com/cosmos/ibc/blob/main/spec/core/ics-005-port-allocation/README.md
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.