Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibc-app-nft-transfer): compile without default features #1195

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Apr 24, 2024

Closes: #XXX

Description

ibc-app-nft-transfer needs base64 with alloc feature.

check-features was disabled before in favor of status check during merge group checks. But it has some nuances. Refer to #1174's description.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy requested a review from seanchen1991 April 24, 2024 19:22
@rnbguy rnbguy marked this pull request as ready for review April 24, 2024 19:22
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (d72fb58) to head (43b8113).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1195   +/-   ##
=======================================
  Coverage   64.33%   64.33%           
=======================================
  Files         229      229           
  Lines       22083    22083           
=======================================
  Hits        14208    14208           
  Misses       7875     7875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy changed the title fix: nft-transfer compilation without default feature fix(ibc-app-nft-transfer): compilate without default features Apr 24, 2024
@rnbguy rnbguy changed the title fix(ibc-app-nft-transfer): compilate without default features fix(ibc-app-nft-transfer): compile without default features Apr 24, 2024
@seanchen1991 seanchen1991 added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 23b26bb Apr 24, 2024
19 checks passed
@seanchen1991 seanchen1991 deleted the rano/ci/enable-check-features branch April 24, 2024 20:18
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* enable cargo feature check

* fix no default compile

* nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants