Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: add macro for schema support to queries #1187

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

crodriguezvega
Copy link

@crodriguezvega crodriguezvega commented Apr 22, 2024

Bringing here these changes so that query support is added to schema.

Closes: #1191

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.35%. Comparing base (41348af) to head (39e407e).

❗ Current head 39e407e differs from pull request most recent head 095559f. Consider uploading reports for the commit 095559f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1187       +/-   ##
=========================================
+ Coverage      0   64.35%   +64.35%     
=========================================
  Files         0      229      +229     
  Lines         0    22081    +22081     
=========================================
+ Hits          0    14211    +14211     
- Misses        0     7870     +7870     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy force-pushed the carlos/add-macro-for-query-support-to-schema branch from 39e407e to 095559f Compare April 24, 2024 11:16
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crodriguezvega ! 🙏

@rnbguy
Copy link
Collaborator

rnbguy commented Apr 24, 2024

Skipping changelog entry as this is part of the cw-context support.

@rnbguy rnbguy added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 68f8c48 Apr 24, 2024
35 checks passed
@rnbguy rnbguy deleted the carlos/add-macro-for-query-support-to-schema branch April 24, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imp(cw-context): support cosmwasm_schema::QueryResponses
2 participants