Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.51.0 #1141

Merged
merged 9 commits into from
Mar 26, 2024
Merged

Release v0.51.0 #1141

merged 9 commits into from
Mar 26, 2024

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Mar 26, 2024

Description

Second revision after the last crates-io publish was unsuccessful.

  • publish ibc-derive with a new patch version, 0.6.1.
  • inform IBC communication team.

@rnbguy rnbguy requested a review from Farhad-Shabani March 26, 2024 11:08
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.06%. Comparing base (aa9c9a8) to head (1453ee0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1141   +/-   ##
=======================================
  Coverage   64.06%   64.06%           
=======================================
  Files         217      217           
  Lines       21049    21049           
=======================================
  Hits        13484    13484           
  Misses       7565     7565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -67,7 +67,7 @@ ibc-core = { version = "0.51.0", path = "./ibc-core", default-feature
ibc-clients = { version = "0.51.0", path = "./ibc-clients", default-features = false }
ibc-apps = { version = "0.51.0", path = "./ibc-apps", default-features = false }
ibc-primitives = { version = "0.51.0", path = "./ibc-primitives", default-features = false }
ibc-derive = { version = "0.6.0", path = "./ibc-derive" }
ibc-derive = { version = "0.6.1", path = "./ibc-derive" }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we add in our changelog that ibc-derive is updated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been doing so, but good to include.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnbguy rnbguy requested a review from seanchen1991 March 26, 2024 12:21
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rnbguy for handling this release 🎉
Would you run the integration tests too (And include it as a step in RELEASES.md) before we leave?

@@ -67,7 +67,7 @@ ibc-core = { version = "0.51.0", path = "./ibc-core", default-feature
ibc-clients = { version = "0.51.0", path = "./ibc-clients", default-features = false }
ibc-apps = { version = "0.51.0", path = "./ibc-apps", default-features = false }
ibc-primitives = { version = "0.51.0", path = "./ibc-primitives", default-features = false }
ibc-derive = { version = "0.6.0", path = "./ibc-derive" }
ibc-derive = { version = "0.6.1", path = "./ibc-derive" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been doing so, but good to include.

README.md Outdated Show resolved Hide resolved
docs/architecture/README.md Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Mar 26, 2024
Co-authored-by: Farhad Shabani <[email protected]>
Signed-off-by: Rano | Ranadeep <[email protected]>
@rnbguy rnbguy merged commit 5407030 into main Mar 26, 2024
21 checks passed
@rnbguy rnbguy deleted the release/v0.51.0 branch March 26, 2024 15:57
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* bump ibc-derive patch version

* update community call info

* run release jobs in seq

* update adr toc

* publish-check and publish never run together

* format

* fix community call frequency

Co-authored-by: Farhad Shabani <[email protected]>
Signed-off-by: Rano | Ranadeep <[email protected]>

* minor changes in changelog

* update ADR status

---------

Signed-off-by: Rano | Ranadeep <[email protected]>
Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants