Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: further minimization of prost imports #1000

Merged
merged 5 commits into from
Dec 2, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Dec 1, 2023

Closes: #997
In continuation of: #998
Integration tests: informalsystems/basecoin-rs#147

Relevant context: #997 (comment)


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (2259108) 70.90% compared to head (16f8e89) 70.86%.

Files Patch % Lines
ibc-clients/ics07-tendermint/src/client_state.rs 0.00% 4 Missing ⚠️
ibc-core/ics23-commitment/types/src/commitment.rs 25.00% 3 Missing ⚠️
ibc-core/ics23-commitment/types/src/merkle.rs 0.00% 3 Missing ⚠️
...it/src/testapp/ibc/clients/mock/consensus_state.rs 66.66% 3 Missing ⚠️
...clients/ics07-tendermint/types/src/client_state.rs 85.71% 1 Missing ⚠️
...ents/ics07-tendermint/types/src/consensus_state.rs 85.71% 1 Missing ⚠️
ibc-clients/ics07-tendermint/types/src/header.rs 85.71% 1 Missing ⚠️
...clients/ics07-tendermint/types/src/misbehaviour.rs 85.71% 1 Missing ⚠️
...stkit/src/testapp/ibc/clients/mock/client_state.rs 85.71% 1 Missing ⚠️
...stkit/src/testapp/ibc/clients/mock/misbehaviour.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   70.90%   70.86%   -0.05%     
==========================================
  Files         178      178              
  Lines       17905    17869      -36     
==========================================
- Hits        12696    12663      -33     
+ Misses       5209     5206       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review December 1, 2023 18:41
@Farhad-Shabani Farhad-Shabani merged commit eafdd30 into main Dec 2, 2023
15 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/further-minimizing-prost branch December 2, 2023 05:16
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* imp: further minimizing prost imports

* fix: merkle proof extraction in ics07

* chore: update Cargo.lock

* chore: clean ups

* chore: touch ups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Minimize prost dependency via ToVec trait
2 participants