optimization: reduce heap allocation (#970)

* optimization: reduce heap allocation Prefer str::from_utf8 over String::from_utf8 to avoid unnecesary heap allocation * fmt * chore: add unclog --------- Co-authored-by: Farhad Shabani <[email protected]>
cosmos · Nov 22, 2023 · 71df7e8 · 71df7e8
1 parent 4596f88
commit 71df7e8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.changelog/unreleased/improvements/970-reduce-heap-allocation.md b/.changelog/unreleased/improvements/970-reduce-heap-allocation.md
@@ -0,0 +1,3 @@
+- Reduce heap allocation by using `str` instead of `String` places we convert
+  domain event attributes to the ABCI event attributes
+  ([\#970](https://github.com/cosmos/ibc-rs/issues/970))
diff --git a/ibc-core/ics02-client/types/src/events.rs b/ibc-core/ics02-client/types/src/events.rs
@@ -153,7 +153,7 @@ impl From<HeaderAttribute> for abci::EventAttribute {
     fn from(attr: HeaderAttribute) -> Self {
         (
             HEADER_ATTRIBUTE_KEY,
-            String::from_utf8(hex::encode(attr.header))
+            str::from_utf8(&hex::encode(attr.header))
                 .expect("Never fails because hexadecimal is valid UTF-8"),
         )
             .into()

diff --git a/ibc-core/ics04-channel/types/src/events/packet_attributes.rs b/ibc-core/ics04-channel/types/src/events/packet_attributes.rs
@@ -59,7 +59,7 @@ impl TryFrom<PacketDataAttribute> for Vec<abci::EventAttribute> {
                 .into(),
             (
                 PKT_DATA_HEX_ATTRIBUTE_KEY,
-                String::from_utf8(hex::encode(attr.packet_data))
+                str::from_utf8(&hex::encode(attr.packet_data))
                     .expect("Never fails because hexadecimal is valid UTF8"),
             )
                 .into(),
@@ -329,7 +329,7 @@ impl TryFrom<AcknowledgementAttribute> for Vec<abci::EventAttribute> {
                 .into(),
             (
                 PKT_ACK_HEX_ATTRIBUTE_KEY,
-                String::from_utf8(hex::encode(attr.acknowledgement))
+                str::from_utf8(&hex::encode(attr.acknowledgement))
                     .expect("Never fails because hexadecimal is always valid UTF-8"),
             )
                 .into(),

diff --git a/ibc-primitives/src/prelude.rs b/ibc-primitives/src/prelude.rs
@@ -4,5 +4,5 @@ pub use alloc::borrow::ToOwned;
 pub use alloc::boxed::Box;
 pub use alloc::string::{String, ToString};
 pub use alloc::vec::Vec;
-pub use alloc::{format, vec};
+pub use alloc::{format, str, vec};
 pub use core::prelude::v1::*;