Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serde an optional dependency, only enabled with the serde feature #152

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 4, 2023

There is no reason to pull in the serde dependency if it's not actually needed.

@romac romac marked this pull request as ready for review October 4, 2023 15:24
@romac romac requested a review from Farhad-Shabani October 4, 2023 15:24
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. 👍🏻

@romac romac force-pushed the romac/optional-serde branch from af849d5 to 05a87ee Compare October 4, 2023 16:45
@romac romac merged commit f2adeea into main Oct 4, 2023
9 checks passed
@romac romac deleted the romac/optional-serde branch October 4, 2023 16:45
ljoss17 added a commit that referenced this pull request Oct 10, 2023
ibc-proto-rs v0.37.0

*October 4th, 2023*

This release updates `prost` to v0.12 and `tonic` to v0.10,
and makes `serde` an optional dependency, now only enabled with the `serde` feature.

FEATURES:

- Update `prost` to v0.12 and `tonic` to v0.10
  (#145)

IMPROVEMENTS:

- Make `serde` an optional dependency, now only enabled with the `serde` feature
  (#152)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants