Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate words #7674

Merged
merged 5 commits into from
Dec 17, 2024
Merged

chore: remove duplicate words #7674

merged 5 commits into from
Dec 17, 2024

Conversation

lfgtwo
Copy link
Contributor

@lfgtwo lfgtwo commented Dec 12, 2024

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor

Hm, can't tell why markdown link checker is messed up here?

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, will merge if markdown checker doesn't complain again.

@lfgtwo
Copy link
Contributor Author

lfgtwo commented Dec 13, 2024

Lgtm, will merge if markdown checker doesn't complain again.

@DimitrisJim seems some .md check failed

ERROR: 1 dead links found!
[✖] https://github.com/cosmos/ibc-go/tree/main/.github/compatibility-test-matrices → Status: 404
(node:1527) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

introduce in PR: Dynamically generate compatibility test files (#7547)

These documents may need to have these links removed, or the document descriptions adjusted. I'm not very familiar with the background, or it might be more appropriate for you to modify them.

image

Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@DimitrisJim DimitrisJim added this pull request to the merge queue Dec 17, 2024
Merged via the queue into cosmos:main with commit fa77756 Dec 17, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants