Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Resource instance factory #31

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Fix: Resource instance factory #31

wants to merge 15 commits into from

Conversation

franzlst
Copy link

The instance factory checked for a list by checking for a __iter__ property. However, URIRef also implements this property, as it is a string type and string can be iterated. It is replaced in this fix by directly checking if the value is a URIRef.

PonteIneptique and others added 15 commits September 11, 2018 17:12
@PonteIneptique
Starting conversion
464cfa3
@PonteIneptique
Fixed a little more issues
316da0d
@PonteIneptique
Does it work ???
705671b
@PonteIneptique
Adding future because I forgot
770c63e
@PonteIneptique
Remove PyTest folder
8de7372
@PonteIneptique
Adding python3
c4b51f9
@PonteIneptique
Cleaning up some hacks with past.builtins
89d8418
@PonteIneptique
Moved type(x) in [*y] to isinstance()
18073f8
@PonteIneptique
Simplify travis yaml file
79ffca6
@mromanello
fixed type check in surf.query.validate_statement() as per issue co…
0f12510 
…sminbasca#19
@mromanello
Merge branch 'master' of https://github.com/PonteIneptique/surfrdf in…
7028da4 
…to surf-py3
@mromanello
upgrade setuptools before running tests + added testing for py36
1b66c8d
@mromanello
adding testing for py36 instead of py26
4554360
@PonteIneptique
Bugfix : calling .save() or is_present() methods of Resource raise ex…
6633a84 
…ception

A fix to issue cosminbasca#1
@franzlst
fix(resurce/instance_factory): fix check for lists
8eda391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franzlst @PonteIneptique @mromanello