Add button to change app time to system time #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Carifio24 and @johnarban, I styled the "now" button and added some updates to the splash and intro overlays. If you get a chance, can one of you please check if it works ok for you? If so, you can merge. Thanks! |
johnarban
approved these changes
Apr 8, 2024
|
I have checked and fixed an issue with the geolocation button not updating the text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button that changes the app time to the system time, clamped to be within our min and max time values on the slider. Currently I've set the button to be disabled when the current time is outside of that range.
Since the system time isn't reactive, I've set a function to run on a 1-second interval that checks whether the system time is inside of the range. Also, while WWT has a function for resetting to the current system time, we would also need to update the app time, which triggers a WWT time update. Thus there's really no benefit - we can just update the app time and let the watcher update WWT.
Marking as a draft so that we can set up styling.