Merge pull request #118 from Carifio24/measurements-no-student-404

Give a 404 from measurements endpoint if student doesn't exist
cosmicds · Jul 3, 2024 · fe30ad8 · fe30ad8
2 parents 1d0f226 + e544236
commit fe30ad8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/stories/hubbles_law/router.ts b/src/stories/hubbles_law/router.ts
@@ -188,7 +188,10 @@ router.delete("/sample-measurement/:studentID/:measurementNumber", async (req, r
 router.get("/measurements/:studentID", async (req, res) => {
   const params = req.params;
   const studentID = parseInt(params.studentID);
-  const measurements = await getStudentHubbleMeasurements(studentID);
+  const student = await findStudentById(studentID);
+  const measurements = student !== null ?
+    await getStudentHubbleMeasurements(studentID) :
+    null;
   const status = measurements === null ? 404 : 200;
   res.status(status).json({
     student_id: studentID,