Added blinkContinuous function #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix typo in blink function and not affecting existing projects a blinkContinuous function was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
transition.blinkfunction there is a typo: not existingeasing.continousLoopis used instead ofeasing.continuousLoop.This is cause blinked object to fade out smooth and then instant fade in since
easing.linearis used for transition excepteasing.continousLoopwhich is equals tonil.The bug appeared on September 11, 2013 with the release of version 2.0 of transition framework, when the function itself was added (initially with this error).
I cannot find any topics related to this behaviour on forum neither issue on Github or Discord. Maybe because of this behaviour falls under the definition of "blinking" and doesn`t arise any questions.
Anyway, i doubt this is desired behaviour that developers wanted to implement.
To fix this typo and not affect any of millions existing projects I added a new function
transition.blinkContinuouswith correctcontinuousLoop.Here you can see the difference:
.