feat: dynamic threshold sphere #1598
Open
+1,004
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add dynamic sphere * fix: Performance issues on threshold sphere * performance * feat: Create segmentation voxel manager in initial create of volume * Faster fill for fixing features * performance: Fix the performance of island removal * fix restore of mixed islands * fix external island removal on non-acquisition * Performance and planar filling improvements * Fix flood fill not being planar * Remove invalid points in shape * feat: Add a labelmap statistics calculator (#2) * fix: Change to names for statistics so that other implementations can be added * Fix build issues * feat: Add working statistics calcs * fix: Add stats to the labelmap calculator * Compute labelmap statistics and lesion glycolysis * PR comments * PR comments * PR - comments added * PR review comments * PR fixes - mostly cleanup * Improvements to threshold out of plane * Missed a fix on the sphere change
|
|
❌ Deploy Preview for cornerstone-3d-docs failed. Why did it fail? →
|
sedghi
reviewed
Nov 28, 2024
| @@ -16,7 +16,9 @@ export default class VolumetricCalculator extends BasicStatsCalculator { | |||
|
|
|||
| // Add the volumetric units | |||
| const volumeUnit = spacing ? 'mm\xb3' : 'voxels\xb3'; | |||
| const volumeScale = spacing ? spacing[0] * spacing[1] * spacing[2] : 1; | |||
| const volumeScale = spacing | |||
| ? spacing[0] * spacing[1] * spacing[2] * 1000 | |||
sedghi
reviewed
Nov 28, 2024
There was a problem hiding this comment.
everything looks updated, and good to me
I couldn't figure out the
await volumeLoader.createAndCacheDerivedLabelmapVolume(volumeId, {
volumeId: segmentationId,
voxelRepresentation: Enums.VoxelManagerEnum.RLE,
});
It does not work after cornerstone3D 2.0 for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a variety of changes to the
common/reviews/api/core.api.mdfile and several other files, focusing on adding new functionality, improving existing interfaces, and making minor corrections. The most important changes include adding new methods and types to theVoxelManagerandRLEVoxelMapclasses, introducing theVoxelManagerEnum, and making some minor adjustments to existing types and functions.Additions to
VoxelManagerandRLEVoxelMap:RLEVoxelMapsuch asdelete,fillFrom,findAdjacents,floodFill,forEach, andforEachRowto enhance its functionality. [1] [2]VoxelManagerEnumto manage different voxel representations, and addedcreateRLEHistoryVoxelManagerstatic method toVoxelManager. [1] [2]Enhancements to types and interfaces:
getTypedArraymethod toPointsManagerto retrieve the underlying data array. [1] [2]PixelDataTypedArrayStringto include'none'as a valid type. [1] [2]Minor corrections and improvements:
multiVolumeCanvasToWorld/index.ts.VoxelManagerEnumto theenums/index.tsexport list. [1] [2]These changes improve the functionality and flexibility of the voxel management system and enhance the overall codebase.