Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump netlify-cli from 14.3.1 to 17.28.0 #1335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlopes90
Copy link
Contributor

netlify-cli v14.3.1

λ yarn install
yarn install v1.22.22
$ node preinstall.js
preinstall.js
No GITHUB_TOKEN found, skipping private repo customization
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning "netlify-cli > @netlify/[email protected]" has unmet peer dependency "@opentelemetry/api@~1.8.0".
warning "netlify-cli > @netlify/build > @netlify/[email protected]" has unmet peer dependency "@opentelemetry/api@~1.8.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.0.0 <1.9.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.3.0 <1.9.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.0.0 <1.9.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.0.0 <1.9.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/otlp-transformer > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.0.0 <1.9.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/otlp-transformer > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.0.0 <1.9.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/otlp-transformer > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.4.0 <1.9.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/otlp-transformer > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.3.0 <1.9.0".
warning "netlify-cli > @netlify/zip-it-and-ship-it > @netlify/serverless-functions-api > @opentelemetry/otlp-transformer > @opentelemetry/[email protected]" has unmet peer dependency "@opentelemetry/api@>=1.0.0 <1.9.0".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "@icr/[email protected]".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "@kitware/[email protected]".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "@types/d3-array@^3.0.4".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "@types/d3-interpolate@^3.0.1".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "d3-array@^3.2.3".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "d3-interpolate@^3.0.1".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "gl-matrix@^3.4.3".
warning "workspace-aggregator-ef7aa583-dc3c-4e7d-8ae8-6001561653c7 > @cornerstonejs/core > @kitware/[email protected]" has unmet peer dependency "wslink@>=1.1.0 || ^2.0.0".
warning "workspace-aggregator-ef7aa583-dc3c-4e7d-8ae8-6001561653c7 > docs > @docusaurus/core > [email protected]" has unmet peer dependency "react-loadable@*".
warning "workspace-aggregator-ef7aa583-dc3c-4e7d-8ae8-6001561653c7 > docs > @docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "workspace-aggregator-ef7aa583-dc3c-4e7d-8ae8-6001561653c7 > docs > @docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "search-insights@>= 1 < 3".
warning "workspace-aggregator-ef7aa583-dc3c-4e7d-8ae8-6001561653c7 > docs > @docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
[5/5] Building fresh packages...
[13/14] ⠐ netlify-cli
[-/14] ⠐ waiting...
[-/14] ⠐ waiting...
[-/14] ⠈ waiting...
error C:\wamp64\www\projects\my-fork\fork-cornerstone3D\node_modules\netlify-cli: Command failed.
Exit code: 1
Command: node ./scripts/postinstall.mjs
Arguments:
Directory: C:\wamp64\www\projects\my-fork\fork-cornerstone3D\node_modules\netlify-cli
Output:
C:\wamp64\www\projects\my-fork\fork-cornerstone3D\node_modules\netlify-cli\node_modules\@octokit\endpoint\dist-node\index.js:22
    if (isPlainObject.isPlainObject(options[key])) {
                      ^

TypeError: isPlainObject.isPlainObject is not a function
    at C:\wamp64\www\projects\my-fork\fork-cornerstone3D\node_modules\netlify-cli\node_modules\@octokit\endpoint\dist-node\index.js:22:23
    at Array.forEach (<anonymous>)
    at mergeDeep (C:\wamp64\www\projects\my-fork\fork-cornerstone3D\node_modules\netlify-cli\node_modules\@octokit\endpoint\dist-node\index.js:21:24)
    at merge (C:\wamp64\www\projects\my-fork\fork-cornerstone3D\node_modules\netlify-cli\node_modules\@octokit\endpoint\dist-node\index.js:63:25)
    at withDefaults (C:\wamp64\www\projects\my-fork\fork-cornerstone3D\node_modules\netlify-cli\node_modules\@octokit\endpoint\dist-node\index.js:357:20)
    at Object.<anonymous> (C:\wamp64\www\projects\my-fork\fork-cornerstone3D\node_modules\netlify-cli\node_modules\@octokit\endpoint\dist-node\index.js:385:18)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32)

Update netlify-cli v17.28.0

λ yarn install
yarn install v1.22.22
$ node preinstall.js
preinstall.js
No GITHUB_TOKEN found, skipping private repo customization
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "@icr/[email protected]".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "@kitware/[email protected]".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "@types/d3-array@^3.0.4".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "@types/d3-interpolate@^3.0.1".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "d3-array@^3.2.3".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "d3-interpolate@^3.0.1".
warning " > @cornerstonejs/[email protected]" has unmet peer dependency "gl-matrix@^3.4.3".
warning "workspace-aggregator-7715c543-d35e-41c6-b75a-fef823f8c9fb > @cornerstonejs/core > @kitware/[email protected]" has unmet peer dependency "wslink@>=1.1.0 || ^2.0.0".
warning "workspace-aggregator-7715c543-d35e-41c6-b75a-fef823f8c9fb > docs > @docusaurus/core > [email protected]" has unmet peer dependency "react-loadable@*".
warning "workspace-aggregator-7715c543-d35e-41c6-b75a-fef823f8c9fb > docs > @docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "workspace-aggregator-7715c543-d35e-41c6-b75a-fef823f8c9fb > docs > @docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "search-insights@>= 1 < 3".
warning "workspace-aggregator-7715c543-d35e-41c6-b75a-fef823f8c9fb > docs > @docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
[5/5] Building fresh packages...
success Saved lockfile.
$ husky install
husky - Git hooks installed
Done in 110.69s.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit e4a6f65
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6673fcae09af390009d05129
😎 Deploy Preview https://deploy-preview-1335--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Jun 26, 2024

I'm not sure why all the CI is failing

@jlopes90
Copy link
Contributor Author

jlopes90 commented Jun 26, 2024

Because of the yarn.lock file. I deleted that file and it works. Should I add it to gitignore or something?

@jlopes90
Copy link
Contributor Author

or update yarn install and it works.

@jlopes90
Copy link
Contributor Author

jlopes90 commented Jun 26, 2024

Which one should I yarn install or gitignore?

@jlopes90 jlopes90 changed the title chore(version): update netlify-cli chore(deps): bump netlify-cli from 14.3.1 to 17.28.0 Jun 26, 2024
@jlopes90
Copy link
Contributor Author

@sedghi
Copy link
Member

sedghi commented Jul 24, 2024

Do we need this? seems like it is the local cli?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants