Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PerseveranceScraper RSpec test coverage #148

Merged
merged 5 commits into from
Apr 13, 2021

Conversation

mtilda
Copy link

@mtilda mtilda commented Apr 10, 2021

Fix the failing RSpec test PerseveranceScraper.scrape should create photo objects (#146) by altering the expected change in photo count from 205 to 34.

The json data only contains 34 photos:
https://mars.nasa.gov/rss/api/?feed=raw_images&category=mars2020&feedtype=json&sol=1

@mtilda
Copy link
Author

mtilda commented Apr 10, 2021

Pushing solutions for issues #149 and #150 to this branch. Now test coverage is at 100%!

@mtilda mtilda changed the title Fix test 'PerseveranceScraper.scrape should create photo objects' Fix PerseveranceScraper RSPpec test coverage Apr 10, 2021
@mtilda mtilda changed the title Fix PerseveranceScraper RSPpec test coverage Fix PerseveranceScraper RSpec test coverage Apr 10, 2021
@corincerami
Copy link
Owner

Thanks 👍

@corincerami corincerami merged commit 2c4e67d into corincerami:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants