This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
add custom etcd image to vault-service CRD #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will also need to add to type VaultServiceSpec.EtcdRepository in https://github.com/coreos/vault-operator/blob/master/pkg/apis/vault/v1alpha1/types.go#53
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The etcd-operator allows the customization of the etcd image in the etcd CRD named 'repository', this PR extends that option to the vault-operator as well using the VaultServiceSpec named 'EtcdRepository'.
I am not able to test this, so please verify that
if v.Spec.EtcdRepository != nil { etcdCluster.Spec.Repository = v.Spec.EtcdRepository }will correctly set the Repository and it doesnt need a pointer or != "".