Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins/config: add JCASC dropin for jms-messaging-plugin #51

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 17, 2023

This configures the JMS messaging plugin to connect to the public endpoint of the Fedora messaging bus.

The tricky thing is passing in the keystores. The plugin does not support using Jenkins credentials[1] so we can't leverage kubernetes-credentials-provider.

We could do it the old way, which is to mount the secret into the Jenkins pod, but since d6d1f61, CoreOS CI now uses the exact same jenkins.yaml manifest as the production pipeline and we don't want to bind mount it there.

Instead, we hack around this by just baking the keystores in the Jenkins image at $JENKINS_HOME/jms-messaging-stores.

This configures the JMS messaging plugin to connect to the public
endpoint of the Fedora messaging bus.

The tricky thing is passing in the keystores. The plugin does
not support using Jenkins credentials[[1]] so we can't leverage
kubernetes-credentials-provider.

We could do it the old way, which is to mount the secret into the
Jenkins pod, but since d6d1f61, CoreOS CI now uses the exact same
`jenkins.yaml` manifest as the production pipeline and we don't want to
bind mount it there.

Instead, we hack around this by just baking the keystores in the Jenkins
image at `$JENKINS_HOME/jms-messaging-stores`.

[1]: jenkinsci/jms-messaging-plugin#263
jlebon added a commit to jlebon/fedora-coreos-pipeline that referenced this pull request Nov 17, 2023
The JMS messaging plugin takes keystores for its credentials. We can't
make them into proper Jenkins credentials nor mount them as Kubernetes
secrets.

Keystores are deprecated and super awkward to work with. Since there's
nothing secret about the public endpoint, let's just add them directly
to git (but with build instructions for posterity).

This pairs with coreos/coreos-ci#51 which makes
CoreOS CI leverage those files and which has more details.
@jlebon
Copy link
Member Author

jlebon commented Nov 17, 2023

Requires: coreos/fedora-coreos-pipeline#931

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jlebon added a commit to coreos/fedora-coreos-pipeline that referenced this pull request Nov 17, 2023
The JMS messaging plugin takes keystores for its credentials. We can't
make them into proper Jenkins credentials nor mount them as Kubernetes
secrets.

Keystores are deprecated and super awkward to work with. Since there's
nothing secret about the public endpoint, let's just add them directly
to git (but with build instructions for posterity).

This pairs with coreos/coreos-ci#51 which makes
CoreOS CI leverage those files and which has more details.
@jlebon jlebon merged commit 984af45 into coreos:main Nov 17, 2023
@jlebon jlebon deleted the pr/add-jms-config branch November 17, 2023 20:25
aaradhak pushed a commit to aaradhak/fedora-coreos-pipeline that referenced this pull request May 14, 2024
The JMS messaging plugin takes keystores for its credentials. We can't
make them into proper Jenkins credentials nor mount them as Kubernetes
secrets.

Keystores are deprecated and super awkward to work with. Since there's
nothing secret about the public endpoint, let's just add them directly
to git (but with build instructions for posterity).

This pairs with coreos/coreos-ci#51 which makes
CoreOS CI leverage those files and which has more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants