updated changelog, modified edit node to edit icon/canvas before node…

… position, in case it gets broadcasted out
coreemu · Sep 15, 2020 · d43d854 · d43d854
1 parent 4dad3f5
commit d43d854
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,24 @@
+## 2020-09-15 CORE 7.2.0
+
+* Installation
+    * locked down version of ospf-mdr installed in automated install
+    * locked down version of emane to v1.2.5 in automated emane install
+    * added option to install locally using the -l option
+* core-daemon
+    * improve error when retrieving services that do not exist, or failed to load
+    * fixed issue with writing/reading emane node interface configurations to xml
+    * fixed issue with not setting the emane model when creating a node
+    * added common utility method for getting a emane node interface config id in core.utils
+    * fixed issue running emane on more than one interface for a node
+    * fixed issue validating paths when creating emane transport xml for a node
+    * fixed issue avoiding multiple calls to shutdown, if already in shutdown state
+* core-pygui
+    * fixed issue configuring emane for a node interface
+* gRPC API
+    * added wrapper client that can provide type hinting and a simpler interface at core.api.grpc.clientw
+    * fixed issue creating sessions that default to having a very large reference scale
+    * fixed issue with GetSession returning control net nodes
+
 ## 2020-08-21 CORE 7.1.0
 
 * Installation

diff --git a/daemon/core/emulator/session.py b/daemon/core/emulator/session.py
@@ -576,17 +576,10 @@ def edit_node(self, node_id: int, options: NodeOptions) -> None:
         :return: nothing
         :raises core.CoreError: when node to update does not exist
         """
-        # get node to update
         node = self.get_node(node_id, NodeBase)
-
-        # set node position and broadcast it
-        self.set_node_position(node, options)
-
-        # update attributes
         node.canvas = options.canvas
         node.icon = options.icon
-
-        # provide edits to sdt
+        self.set_node_position(node, options)
         self.sdt.edit_node(node, options.lon, options.lat, options.alt)
 
     def set_node_position(self, node: NodeBase, options: NodeOptions) -> None: