forked from crashub/crash
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corda/crash.shell is not obtainable from jitpack.io #23
Open
archiecobbs
wants to merge
37
commits into
master
Choose a base branch
from
1.2.x
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: plugins/mail/pom.xml
serverKey resource wasn't being set when ssh.keypath property was used. This made the plugin basically ignore a key that is being set from a property.
…nse different than ShellResponse.OK
…with a response different than ShellResponse.OK
…he underlying SSH server Added crash.ssh.auth-timeout property to set custom authentication timeout of the underlying SSH server
ghost
reviewed
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule: 2-PEM-PRIVATE
Severity:
File: shell/ssh/src/main/resources/crash/hostkey.pem
Lines: 1
Scanner: Secret Diver
More Info
Contains a private key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this project supposed to be public??
Filing a PR because you don't have an issue tracker enabled (why not?)
The README says:
OK fine. But when I do that all of the artifacts require authorization - it looks like they are setup in a JitPack private repository?
This top-level POM loads fine: https://jitpack.io/#corda/crash
But not any of the JAR files, e.g.: https://jitpack.io/#corda/crash.shell
Instead you get "Please Sign In first".
Sorry if I'm missing something obvious.