chore: deletes content temporary file on close.

[jcchavezs]

Fixes #922.

cc @UnveilTech

[victoredvardsson]

Bumping this one, would be nice if could be fixed. Right now i have to delete body* and crzmp* and body* manually in our env.

[jcchavezs]

I will work on this tomorrow

[jcchavezs]

This is green. I will be merging it soon.

[M4tteoP]

The initial Issue this PR meant to fix was about crzmp* files, generated by the multipart body processor. Just wanted to raise that we might have to double-check body* files:

coraza/internal/corazawaf/body_buffer.go

Line 78 in 5fd8d62

br.writer, err = os.CreateTemp(br.options.TmpPath, "body*")

I think that they are not added to filesTmpNames being really just a way to buffer the body on disk, and not files meant for @inspectFile. Therefore, we might still have to delete these files

That being said, looks good to me!

[jcchavezs]

Just wanted to raise that we might have to double-check body* files

Good point, yeah we delete them already on reset (when transaction is being closed):

coraza/internal/corazawaf/body_buffer.go

Line 168 in 1455f1d

return os.Remove(w.Name())