Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reverse transformation support #870

Closed
wants to merge 4 commits into from
Closed

Conversation

jptosso
Copy link
Member

@jptosso jptosso commented Aug 24, 2023

I found this interesting use case, when payloads are being reversed to avoid detection. t:reverse will help to detect them.

@jptosso jptosso requested a review from a team as a code owner August 24, 2023 15:24
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ff1f76) 82.72% compared to head (34b6cae) 81.68%.
Report is 11 commits behind head on main.

❗ Current head 34b6cae differs from pull request most recent head d87c002. Consider uploading reports for the commit d87c002 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   82.72%   81.68%   -1.04%     
==========================================
  Files         162      161       -1     
  Lines        9080     9057      -23     
==========================================
- Hits         7511     7398     -113     
- Misses       1319     1409      +90     
  Partials      250      250              
Flag Coverage Δ
default 76.77% <100.00%> (-1.06%) ⬇️
examples 25.60% <7.69%> (-0.83%) ⬇️
ftw 46.62% <7.69%> (-0.75%) ⬇️
ftw-multiphase 48.80% <7.69%> (-0.74%) ⬇️
tinygo 74.97% <100.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzipi fzipi changed the title add reverse transformation support feat: add reverse transformation support Aug 25, 2023
@jcchavezs jcchavezs requested a review from anuraaga September 26, 2023 07:33
@jcchavezs
Copy link
Member

LGTM.

@jcchavezs
Copy link
Member

jcchavezs commented Oct 2, 2023

Could you please link any documentation where this is being used or requested?

@fzipi
Copy link
Member

fzipi commented Nov 11, 2023

@jptosso Can this be documented somewhere? Looks like this is now in code only, and this is a new transformation that is not available "upstream".

An issue will also help others determine the use case and if matches their needs.

@jcchavezs jcchavezs added the nice to have Feature that will be to provide label Feb 5, 2024
@fzipi
Copy link
Member

fzipi commented Feb 8, 2024

@jptosso ping

@jptosso jptosso closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback nice to have Feature that will be to provide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants