Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint go versions. #1246

Merged
merged 1 commit into from
Dec 12, 2024
Merged

chore: lint go versions. #1246

merged 1 commit into from
Dec 12, 2024

Conversation

jcchavezs
Copy link
Member

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

@jcchavezs jcchavezs requested a review from a team as a code owner December 12, 2024 10:39
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (10ade1e) to head (00bff63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files         168      168           
  Lines        9762     9762           
=======================================
  Hits         7974     7974           
  Misses       1537     1537           
  Partials      251      251           
Flag Coverage Δ
coraza.rule.case_sensitive_args_keys 81.64% <ø> (ø)
coraza.rule.multiphase_valuation 81.68% <ø> (ø)
coraza.rule.no_regex_multiline 81.62% <ø> (ø)
default 81.68% <ø> (ø)
examples+ 16.55% <ø> (ø)
examples+coraza.rule.case_sensitive_args_keys 81.64% <ø> (ø)
examples+coraza.rule.multiphase_valuation 81.51% <ø> (ø)
examples+coraza.rule.no_regex_multiline 81.54% <ø> (ø)
examples+memoize_builders 81.64% <ø> (ø)
examples+no_fs_access 80.96% <ø> (ø)
ftw 81.68% <ø> (ø)
memoize_builders 81.77% <ø> (ø)
no_fs_access 81.13% <ø> (ø)
tinygo 81.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

testing/coreruleset/go.mod Show resolved Hide resolved
@@ -2,6 +2,8 @@ module github.com/corazawaf/coraza/v3/testing/coreruleset

go 1.22.3

toolchain go1.23.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed? we have it only here

@jcchavezs jcchavezs merged commit c938b16 into main Dec 12, 2024
71 checks passed
@jcchavezs jcchavezs deleted the lint_go_versions branch December 12, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants