Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirect action status codes #1183

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: redirect action status codes #1183

merged 2 commits into from
Oct 31, 2024

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Oct 30, 2024

what

  • redirect action should by default redirect using code 302
  • if status action exists, with some specific 3xx codes, then use those

why

  • redirect action is not working as the documentation states

@fzipi
fix: redirect action status codes
e42cfd6 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi requested a review from a team as a code owner October 30, 2024 23:13
@fzipi fzipi mentioned this pull request Oct 30, 2024
Merged
M4tteoP
M4tteoP approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

internal/actions/redirect.go Show resolved Hide resolved
@fzipi
docs: reword redirect description
05c8236 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi merged commit 3719dce into main Oct 31, 2024
6 checks passed
@fzipi fzipi deleted the fix/redirect branch October 31, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4tteoP M4tteoP M4tteoP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzipi @M4tteoP