Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose expected directives for e2e test #1012

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

fionera
Copy link
Contributor

@fionera fionera commented Mar 5, 2024

Closes #1006

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

@fionera fionera requested a review from a team as a code owner March 5, 2024 04:07
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (4ff1f76) to head (763d300).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   82.72%   83.17%   +0.45%     
==========================================
  Files         162      162              
  Lines        9080     7553    -1527     
==========================================
- Hits         7511     6282    -1229     
+ Misses       1319     1023     -296     
+ Partials      250      248       -2     
Flag Coverage Δ
default 83.17% <ø> (+5.33%) ⬆️
examples 83.17% <ø> (+56.74%) ⬆️
ftw 83.17% <ø> (+35.80%) ⬆️
ftw-multiphase 83.17% <ø> (+33.62%) ⬆️
tinygo 83.17% <ø> (+7.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

http/e2e/cmd/httpe2e/main.go Outdated Show resolved Hide resolved
@fionera fionera force-pushed the expose-e2e-directives branch from 021a472 to 31eff8d Compare March 5, 2024 18:59
@M4tteoP M4tteoP merged commit 9184eee into corazawaf:main Mar 8, 2024
9 checks passed
@fionera fionera deleted the expose-e2e-directives branch March 8, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: Expose expected config and e2e test cases
2 participants